This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

why not modify the current nimble peripheral example (https://github.com/apache/nuttx-apps/blob/master/examples/nimble/nimble_main.c)? do we need 2 different examples for this?

why not modify the current nimble peripheral example (https://github.com/apache/nuttx-apps/blob/master/examples/nimble/nimble_main.c)? do we need 2 different examples for this?

I was debating this with myself. As stated, I based them on the mynewt-nimble apps and hence the peripheral is quite different from the existing one. I could, of course, modify the existing one losing the tight connection to the mynewt-nimble app. The other options are maintaining the existing one along side my contribution for legacy reasons, or purging the existing one (my preference). What do you think? @raiden00pl

@maxikrie The Mynewt coding standard is far from the NuttX coding standard, so the code will be a lot different anyway. Keeping 2 examples demonstrating the same functionality seems pointless to me. The easiest thing to do would be to change the name of existing examples/nimble to examples/nimble_bleprph (or nimble_prph) and add all your changes there.
Or you can delete examples/nimble but then you will have more work to adapt the Mynewt code to the NuttX coding standard.

CI checkpatch is now fixed, CI restarted :-)

Source code still needs reformat, @maxikrie please take a look at:

• https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md
• https://nuttx.apache.org/docs/latest/contributing/coding_style.html

@cederom Is there a way to check whether my changes will pass the check before committing? I read the documentation on pre-commit, but it seems that this only applies to the nuttx repository - at least this repository is missing the required .pre-commit-config.yaml.

I have installed pre-commit in the nuttx repository and tested it on branch nuttx-12.7.0, where everything is fine. I then naively tried from within the nuttx repository:
pre-commit run --files ../apps/*
which gives all sorts of strange errors.

@cederom Is there a way to check whether my changes will pass the check before committing? I read the documentation on pre-commit, but it seems that this only applies to the nuttx repository - at least this repository is missing the required .pre-commit-config.yaml.

I have installed pre-commit in the nuttx repository and tested it on branch nuttx-12.7.0, where everything is fine. I then naively tried from within the nuttx repository: pre-commit run --files ../apps/* which gives all sorts of strange errors.

please run the following command to check the style:
../nuttx/tools/checkpatch.sh -g HEAD~...HEAD

ping @maxikrie

I fixed the formatting issues and fixed an error in the Makefile (I previously had only tested the CMake build), but there are again failed checks. Can somebody check? I am not sure what to make of them.. @xiaoxiang781216 @cederom

Thank you @maxikrie :-)

Most of the formatting issues detected by CI are in the codebase already:
https://github.com/apache/nuttx-apps/actions/runs/12679172534/job/35340025084?pr=2807

Looks like these still needs an update?

• the ones with comment.
• builtin/builtin_list.c.
• canutils/candump/candump.c

I am not sure, should I look into this? I am just checking since I didn't touch these and they didn't appear to be an issue when I run the nxstyle tool. I want to make sure this is not an issue with the CI.

does anyone have any idea why CI is returning nxstyle errors unrelated to PR content?

What is this Unchanged files with check annotations Preview ? any ideas @lupyuen @simbit18 @xiaoxiang781216 ?

@maxikrie Could you try rebasing with the latest master branch? The branch looks rather old (Oct 30).

Also the CI Check seems to be running OK for the latest builds. Thanks!

https://github.com/apache/nuttx-apps/actions/workflows/check.yml

ping @maxikrie :-)

@maxikrie please sqaush your patch into by git rebase --interactive HEAD~8

Thank you @maxikrie, awesome work!! :-) Please squash so we have everything bundled into one single commit with common description and we are ready to go :-)